eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-11-08 20:12:23 +00:00
Code Activity

Bug 5192: Fixed double attaching of mobile StartView which breaks the

Browse Source 
slider
This commit is contained in:
Steffen Schaefer committed 2020-01-30 15:34:09 +01:00
1 parent 3bbc001bfe
commit c72ab38bf2
2 files changed
+8 -5
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/mobile/places/start/StartActivity.java
+3 -4
View File
@@ -15,7 +15,6 @@ import com.sap.sailing.gwt.home.mobile.places.start.StartView.Presenter;
import com.sap.sailing.gwt.home.shared.app.ActivityCallback;
import com.sap.sailing.gwt.home.shared.app.PlaceNavigation;
import com.sap.sailing.gwt.home.shared.places.start.StartPlace;
import com.sap.sailing.gwt.home.shared.refresh.RefreshManager;
import com.sap.sailing.gwt.home.shared.refresh.RefreshManagerWithErrorAndBusy;
import com.sap.sse.gwt.dispatch.shared.commands.ListResult;
@@ -33,11 +32,13 @@ public class StartActivity extends AbstractActivity implements Presenter {
panel.setWidget(clientFactory.createBusyView());
Window.setTitle(place.getTitle());
final StartView view = new StartViewImpl(StartActivity.this);
final RefreshManagerWithErrorAndBusy refreshManager = new RefreshManagerWithErrorAndBusy(view.asWidget(), panel,
clientFactory.getDispatch(), clientFactory);
clientFactory.getDispatch().execute(new GetStagedEventsAction(true),
new ActivityCallback<ListResult<EventStageDTO>>(clientFactory, panel) {
@Override
public void onSuccess(ListResult<EventStageDTO> result) {
panel.setWidget(view.asWidget());
refreshManager.attachContent();
Window.setTitle(place.getTitle());
view.setFeaturedEvents(result.getValues());
}
@@ -50,8 +51,6 @@ public class StartActivity extends AbstractActivity implements Presenter {
}
});
final RefreshManager refreshManager = new RefreshManagerWithErrorAndBusy(view.asWidget(), panel,
clientFactory.getDispatch(), clientFactory);
refreshManager.add(view.getAnniversariesView(), new GetAnniversariesAction());
}
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/home/shared/refresh/AutoAttachingRefreshManager.java
+5 -1
View File
@@ -34,7 +34,11 @@ public class AutoAttachingRefreshManager extends LifecycleRefreshManager {
@Override
protected void onSuccessfulUpdate() {
if(container != null) {
attachContent();
}
public void attachContent() {
if (container != null) {
LOG.log(Level.FINE, "Attaching refreshable content to container");
container.setWidget(content);
container = null;