eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-10-11 06:40:53 +00:00
Code Activity

provided fix for bug 1524 by also escaping the "\" character

Browse Source
This commit is contained in:
Axel Uhl committed 2013-09-19 09:41:24 +02:00
1 parent 64e4fb34cc
commit cbc2281aa4
2 files changed
+39 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

mobile/com.sap.sailing.racecommittee.app.test/src/com/sap/sailing/racecommittee/app/test/IdentifierTest.java
+38
View File
@@ -37,4 +37,42 @@ public class IdentifierTest {
assertFalse(i1ID.equals(i2ID));
}
@Test
public void testManagedRaceIdentifierUniqueness2() {
final Set<RaceRow> raceRows1 = Collections.emptySet();
final SeriesWithRows series1 = new SeriesWithRowsImpl("ghi\\", /* isMedal */ false, /* raceRows */ raceRows1);
final Set<SeriesWithRows> raceGroupSeries1 = Collections.singleton(series1);
ManagedRaceIdentifier i1 = new ManagedRaceIdentifierImpl("abc", new FleetIdentifierImpl(new FleetImpl("mno.def"), series1,
new RaceGroupImpl("jkl", new BoatClassImpl("505", /* typicallyStartsUpwind */ true), new CourseAreaImpl("Alpha", "Alpha ID"), raceGroupSeries1)));
String i1ID = i1.getId().toString();
final Set<RaceRow> raceRows2 = Collections.emptySet();
final SeriesWithRows series2 = new SeriesWithRowsImpl("ghi.mno\\", /* isMedal */ false, /* raceRows */ raceRows2);
final Set<SeriesWithRows> raceGroupSeries2 = Collections.singleton(series2);
ManagedRaceIdentifier i2 = new ManagedRaceIdentifierImpl("abc", new FleetIdentifierImpl(new FleetImpl("def"), series2,
new RaceGroupImpl("jkl", new BoatClassImpl("505", /* typicallyStartsUpwind */ true), new CourseAreaImpl("Alpha", "Alpha ID"), raceGroupSeries2)));
String i2ID = i2.getId().toString();
assertFalse(i1ID.equals(i2ID));
}
@Test
public void testManagedRaceIdentifierUniqueness3() {
final Set<RaceRow> raceRows1 = Collections.emptySet();
final SeriesWithRows series1 = new SeriesWithRowsImpl("ghi", /* isMedal */ false, /* raceRows */ raceRows1);
final Set<SeriesWithRows> raceGroupSeries1 = Collections.singleton(series1);
ManagedRaceIdentifier i1 = new ManagedRaceIdentifierImpl("abc", new FleetIdentifierImpl(new FleetImpl("def.mno\\"), series1,
new RaceGroupImpl("jkl", new BoatClassImpl("505", /* typicallyStartsUpwind */ true), new CourseAreaImpl("Alpha", "Alpha ID"), raceGroupSeries1)));
String i1ID = i1.getId().toString();
final Set<RaceRow> raceRows2 = Collections.emptySet();
final SeriesWithRows series2 = new SeriesWithRowsImpl("ghi", /* isMedal */ false, /* raceRows */ raceRows2);
final Set<SeriesWithRows> raceGroupSeries2 = Collections.singleton(series2);
ManagedRaceIdentifier i2 = new ManagedRaceIdentifierImpl("mno.abc", new FleetIdentifierImpl(new FleetImpl("def\\"), series2,
new RaceGroupImpl("jkl", new BoatClassImpl("505", /* typicallyStartsUpwind */ true), new CourseAreaImpl("Alpha", "Alpha ID"), raceGroupSeries2)));
String i2ID = i2.getId().toString();
assertFalse(i1ID.equals(i2ID));
}
}
mobile/com.sap.sailing.racecommittee.app/src/com/sap/sailing/racecommittee/app/domain/impl/FleetIdentifierImpl.java
+1 -1
View File
@@ -39,7 +39,7 @@ public class FleetIdentifierImpl implements FleetIdentifier {
}
protected String escapeIdentifierFragment(String fragment) {
return fragment./* this is probably the fix for bug 1524: replace("\\", "\\\\"). */ replace(".", "\\.");
return fragment.replace("\\", "\\\\").replace(".", "\\.");
}
}