eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-10-21 19:50:01 +00:00
Code Activity

removed obsolete unused method from SailingService; enhanced Javadoc

Browse Source 
Change-Id: I4110ee1704c8ff0a6f6e5cf14fcf9ce0d7627c84
This commit is contained in:
Axel Uhl committed 2016-10-28 09:52:40 +02:00
1 parent f8b7fe3b33
commit d1dfdaa768
3 files changed
+6 -21
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/SailingService.java
+2 -7
View File
@@ -529,13 +529,8 @@ public interface SailingService extends RemoteService, FileStorageManagementGwtS
PolarSheetsXYDiagramData createXYDiagramForBoatClass(String itemText);
/**
* Returns mark passings for the competitor. It doesn't wait for the end of an active calculation which will update
* competitor's mark passings. If you want to wait the end of calculations then call
* {@code SailingService#getCompetitorMarkPassings(RegattaAndRaceIdentifier, CompetitorDTO, boolean)} with true flag
* of waitForCalculations parameter
*/
Map<Integer, Date> getCompetitorMarkPassings(RegattaAndRaceIdentifier race, CompetitorDTO competitorDTO);
* @see SailingServiceAsync#getCompetitorMarkPassings(RegattaAndRaceIdentifier, CompetitorDTO, boolean, com.google.gwt.user.client.rpc.AsyncCallback)
*/
Map<Integer, Date> getCompetitorMarkPassings(RegattaAndRaceIdentifier race, CompetitorDTO competitorDTO,
boolean waitForCalculations);
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/SailingServiceAsync.java
+3 -7
View File
@@ -697,17 +697,13 @@ public interface SailingServiceAsync extends ServerInfoRetriever, FileStorageMan
void getRegattas(String manage2SailJsonUrl, AsyncCallback<Iterable<RegattaDTO>> asyncCallback);
/**
* Returns mark passings for the competitor. It doesn't wait for the end of an active calculation which will update
* competitor's mark passings. If you want to wait the end of calculations then call
* {@code SailingService#getCompetitorMarkPassings(RegattaAndRaceIdentifier, CompetitorDTO, boolean)} with true flag
* of waitForCalculations parameter
* Returns mark passings for the competitor. Using the {@code waitForCalculations} parameter callers can control
* whether to obtain a snapshot immediately of wait for pending updates. Waiting may be desirable, e.g., when having
* submitted a fixed mark passing into a race log which triggers the re-calculations asynchronously.
*/
void getCompetitorMarkPassings(RegattaAndRaceIdentifier race, CompetitorDTO competitorDTO,
boolean waitForCalculations, AsyncCallback<Map<Integer, Date>> callback);
void getCompetitorMarkPassings(RegattaAndRaceIdentifier race, CompetitorDTO competitorDTO,
AsyncCallback<Map<Integer, Date>> callback);
void getCompetitorRaceLogMarkPassingData(String leaderboardName, String raceColumnName, String fleetName,
CompetitorDTO competitor, AsyncCallback<Map<Integer, Date>> callback);
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/server/SailingServiceImpl.java
+1 -7
View File
@@ -5805,13 +5805,7 @@ public class SailingServiceImpl extends ProxiedRemoteServiceServlet implements S
}
@Override
public Map<Integer, Date> getCompetitorMarkPassings(RegattaAndRaceIdentifier race, CompetitorDTO competitorDTO) {
return getCompetitorMarkPassings(race, competitorDTO, false);
}
@Override
public Map<Integer, Date> getCompetitorMarkPassings(RegattaAndRaceIdentifier race, CompetitorDTO competitorDTO,
boolean waitForCalculations) {
public Map<Integer, Date> getCompetitorMarkPassings(RegattaAndRaceIdentifier race, CompetitorDTO competitorDTO, boolean waitForCalculations) {
Map<Integer, Date> result = new HashMap<>();
final TrackedRace trackedRace = getExistingTrackedRace(race);
if (trackedRace != null) {