eclipse-sailing-analytics/sailing-analytics
1
0
Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-09-20 04:35:32 +00:00
Code Activity

Bug 4339: Code cleanup and removed code duplications

Browse Source
This commit is contained in:
Steffen Schaefer
2018-07-30 10:59:08 +02:00
parent eb7ae74cd5
commit d2d0f951b5
1 changed files with 12 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/adminconsole/tractrac/TracTracEventManagementPanelPO.java
+12 -18
View File
@@ -226,46 +226,40 @@ public class TracTracEventManagementPanelPO extends PageArea {
}
public void startTrackingForRace(TrackableRaceDescriptor race) {
startTrackingForRaceInternal(race);
startTrackingAndWaitForAjaxRequests();
startTrackingForRacesInternal(Collections.singletonList(race), null);
}
public void startTrackingForRaceAndAwaitBoatClassError(TrackableRaceDescriptor race, String expectedBoatClass) {
startTrackingForRaceInternal(race);
startTracking();
waitForSelectedRacesContainDifferentBoatClassesError(expectedBoatClass);
}
private void startTrackingForRaceInternal(TrackableRaceDescriptor race) {
startTrackingForRacesInternal(Collections.singletonList(race));
startTrackingForRacesInternal(Collections.singletonList(race), expectedBoatClass);
}
public void startTrackingForRaces(List<TrackableRaceDescriptor> races) {
startTrackingForRacesInternal(races);
startTrackingAndWaitForAjaxRequests();
startTrackingForRacesInternal(races, null);
}
private void startTrackingForRacesInternal(List<TrackableRaceDescriptor> races) {
private void startTrackingForRacesInternal(List<TrackableRaceDescriptor> races,
String expectedBoatClassErrorOrNull) {
List<TrackableRaceDescriptor> racesToProcess = new ArrayList<>(races);
CellTablePO<DataEntryPO> table = getTrackableRacesTable();
table.selectEntries(e -> racesToProcess.remove(new TrackableRaceDescriptor(e.getColumnContent("Event"),
e.getColumnContent("Race"), e.getColumnContent("Boat Class"))));
if(!racesToProcess.isEmpty()) {
if (!racesToProcess.isEmpty()) {
throw new IllegalStateException("Not all given races where selected");
}
this.startTracking();
if (expectedBoatClassErrorOrNull == null) {
waitForAjaxRequests();
} else {
waitForSelectedRacesContainDifferentBoatClassesError(expectedBoatClassErrorOrNull);
}
}
public void startTrackingForAllRaces() {
getTrackableRacesTable().selectAllEntries();
startTrackingAndWaitForAjaxRequests();
}
private void startTrackingAndWaitForAjaxRequests() {
startTracking();
waitForAjaxRequests();
}
private void startTracking() {
this.startTrackingButton.click();
}