eclipse-sailing-analytics/sailing-analytics
1
0
Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-09-25 23:16:48 +00:00
Code Activity

Re-generate chart for every change

Browse Source
This commit is contained in:
Papick Garcia Taboada
2016-04-12 16:51:46 +02:00
parent 5875db842f
commit d65a3f4985
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/shared/charts/AbstractCompetitorRaceChart.java
+5 -3
View File
@@ -309,7 +309,7 @@ public abstract class AbstractCompetitorRaceChart<SettingsType extends ChartSett
if (competitorSeries != null) {
chart.removeSeries(competitorSeries, false);
}
Series competitorMarkPassingSeries = markPassingSeriesByCompetitor.get(competitor);
Series competitorMarkPassingSeries = markPassingSeriesByCompetitor.get(coDePair);
if (competitorMarkPassingSeries != null) {
chart.removeSeries(competitorMarkPassingSeries, false);
}
@@ -576,7 +576,9 @@ public abstract class AbstractCompetitorRaceChart<SettingsType extends ChartSett
this.selectedSecondDetailType = newSelectedSecondDetailType;
// TODO There is a bug in the highcharts library which prevents to change the reverse property of the YAxis
// Because we need this functionality we need to recreate the chart each time the YAxis changes
if (oldReversedY0Axis != isY0AxisReversed() || oldReversedY1Axis != isY1AxisReversed()) {
// if (oldReversedY0Axis != isY0AxisReversed() || oldReversedY1Axis != isY1AxisReversed()) {
// WORKAROUND: re-creating chart every time since introduction of dual y-axis, since there is no way to
// reset/ delete axis.
chart = createChart();
if (isZoomed) {
com.sap.sse.common.Util.Pair<Date, Date> zoomRange = timeRangeWithZoomProvider.getTimeZoom();
@@ -584,7 +586,7 @@ public abstract class AbstractCompetitorRaceChart<SettingsType extends ChartSett
} else {
resetMinMaxAndExtremesInterval(/* redraw */ true);
}
}
// }
final String unitY0 = DetailTypeFormatter.getUnit(getSelectedFirstDetailType());
final String labelY0 = unitY0.isEmpty() ? "" : "[" + unitY0 + "]";