fix for bug 3037: use int[0] to encode no discards on regatta; make regatta leaderboard dialog robust for null discarding threshold array

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/RegattaLeaderboardDialog.java

@@ -74,7 +74,9 @@ public abstract class RegattaLeaderboardDialog extends AbstractLeaderboardDialog
             }
             regattaDefinesDiscardsLabel.setVisible(true);
         } else {
-            discardThresholdBoxes.getWidget().setVisible(true);
+            if (discardThresholdBoxes != null) {
+                discardThresholdBoxes.getWidget().setVisible(true);
+            }
             regattaDefinesDiscardsLabel.setVisible(false);
         }
     }

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/RegattaLeaderboardEditDialog.java

@@ -23,7 +23,7 @@ public class RegattaLeaderboardEditDialog extends RegattaLeaderboardDialog {
 
         regattaListBox = createSortedRegattaListBox(existingRegattas, leaderboardDescriptor.getRegattaName());
         regattaListBox.setEnabled(false);
-        if (leaderboardDescriptor.getDiscardThresholds() != null) {
+        if (!getSelectedRegatta().definesSeriesDiscardThresholds()) {
             discardThresholdBoxes = new DiscardThresholdBoxes(this, leaderboardDescriptor.getDiscardThresholds(), stringMessages);
         } // else, the regatta leaderboard obtains its result discarding rule implicitly from the underlying regatta
         adjustVisibilityOfResultDiscardingRuleComponent();

java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/SeriesEditDialog.java

@@ -133,7 +133,7 @@ public class SeriesEditDialog extends DataEntryDialog<SeriesDescriptor> {
         }
         return new SeriesDescriptor(selectedSeries, seriesNameTextBox.getValue(), races, isMedalCheckbox.getValue(),
                 useSeriesResultDiscardingThresholdsCheckbox.getValue() ? discardThresholdBoxes.getDiscardThresholds()
-                        : null, startWithZeroScoreCheckbox.getValue(),
+                        : new int[0], startWithZeroScoreCheckbox.getValue(),
                 firstColumnIsNonDiscardableCarryForwardCheckbox.getValue(), hasSplitFleetContiguousScoringCheckbox.getValue());
     }