removed incorrect URL validation regexp from EventDialog for now

This commit is contained in:
Axel Uhl committed 2020-05-09 14:15:16 +02:00
1 parent 02bae1e095
commit e492cc3759
1 file changed
-20
@@ -12,7 +12,6 @@ import java.util.UUID;
import com.google.gwt.dom.client.Style.Unit;
import com.google.gwt.event.logical.shared.ValueChangeEvent;
import com.google.gwt.event.logical.shared.ValueChangeHandler;
import com.google.gwt.regexp.shared.RegExp;
import com.google.gwt.user.client.ui.CheckBox;
import com.google.gwt.user.client.ui.FocusWidget;
import com.google.gwt.user.client.ui.Grid;
@@ -60,14 +59,6 @@ public abstract class EventDialog extends DataEntryDialogWithDateTimeBox<EventDT
protected ExternalLinksComposite externalLinksComposite;
private final FileStorageServiceConnectionTestObservable storageServiceAvailable;
/**
* We expect only a subset of possible URLs, i.e.:
* https://<hostname>:<port>/<path>
*/
private static RegExp REGEXP_URL = RegExp.compile(
"^(https?)://((?:[\\w-]+\\.)+[a-z]{2,}|localhost)(?::\\d+)?(/[\\w~:@_./$!%&=+*'\",;()-]*)?$",
"i");
protected static class EventParameterValidator implements Validator<EventDTO> {
private StringMessages stringMessages;
@@ -78,13 +69,6 @@ public abstract class EventDialog extends DataEntryDialogWithDateTimeBox<EventDT
this.existingEvents = new ArrayList<EventDTO>(existingEvents);
}
private boolean isValidURL(String input) {
if (input == null || input.isEmpty())
return true;
else
return REGEXP_URL.test(input);
}
@Override
public String getErrorMessage(EventDTO eventToValidate) {
String errorMessage = null;
@@ -135,13 +119,9 @@ public abstract class EventDialog extends DataEntryDialogWithDateTimeBox<EventDT
errorMessage = stringMessages.pleaseEnterNonEmptyCourseArea();
} else if (!unique) {
errorMessage = stringMessages.eventWithThisNameAlreadyExists();
} else if (!isValidURL(eventToValidate.getBaseURL())) {
errorMessage = stringMessages.invalidURL();
}
return errorMessage;
}
}
/**