moved ParameterValueChangeListener from ModifiableDataMiningReportDTO into own file;

hoping to "improve" serializability detection by buggy GWT RPC serializability check
This commit is contained in:
Axel Uhl committed 2024-11-26 00:33:35 +01:00
1 parent 876e9c5450
commit ec2c0ae762
2 files changed
+35 -28

No files matched your search

@@ -45,33 +45,6 @@ public class ModifiableDataMiningReportDTO implements DataMiningReportDTO {
private transient Set<ParameterModelListener> parameterModelListeners;
public static class ParameterValueChangeListener implements ParameterModelListener, Serializable {
private static final long serialVersionUID = 402977347893177440L;
private ModifiableDataMiningReportDTO report;
@Deprecated // for GWT serialization only
ParameterValueChangeListener() {}
public ParameterValueChangeListener(ModifiableDataMiningReportDTO report) {
super();
this.report = report;
}
@Override
public void parameterAdded(DataMiningReportDTO report, FilterDimensionParameter parameter) {
}
@Override
public void parameterRemoved(DataMiningReportDTO report, FilterDimensionParameter parameter) {
}
@Override
public void parameterValueChanged(FilterDimensionParameter parameter, Iterable<? extends Serializable> oldValues) {
report.adjustAllDimensionFiltersInQueriesUsingParameter(parameter);
}
}
/**
* Creates an empty report with no queries and hence no parameter usages.
*/
@@ -94,7 +67,7 @@ public class ModifiableDataMiningReportDTO implements DataMiningReportDTO {
* {@link StatisticQueryDefinitionDTO#getFilterSelection() filter selections} are adjusted to reflect the new
* parameter's {@link FilterDimensionParameter#getValues() value set}.
*/
private void adjustAllDimensionFiltersInQueriesUsingParameter(FilterDimensionParameter parameter) {
void adjustAllDimensionFiltersInQueriesUsingParameter(FilterDimensionParameter parameter) {
for (final Pair<StatisticQueryDefinitionDTO, FilterDimensionIdentifier> usage : getParameterUsages(parameter)) {
// the following cast is safe because addQueryDefinition accepts only ModifiableStatisticQueryDefinitionDTO objects
final ModifiableStatisticQueryDefinitionDTO query = (ModifiableStatisticQueryDefinitionDTO) usage.getA();
@@ -0,0 +1,34 @@
package com.sap.sse.datamining.shared.impl.dto;
import java.io.Serializable;
import com.sap.sse.datamining.shared.dto.DataMiningReportDTO;
import com.sap.sse.datamining.shared.dto.FilterDimensionParameter;
import com.sap.sse.datamining.shared.impl.dto.parameters.ParameterModelListener;
public class ParameterValueChangeListener implements ParameterModelListener, Serializable {
private static final long serialVersionUID = 402977347893177440L;
private ModifiableDataMiningReportDTO report;
@Deprecated // for GWT serialization only
ParameterValueChangeListener() {}
public ParameterValueChangeListener(ModifiableDataMiningReportDTO report) {
super();
this.report = report;
}
@Override
public void parameterAdded(DataMiningReportDTO report, FilterDimensionParameter parameter) {
}
@Override
public void parameterRemoved(DataMiningReportDTO report, FilterDimensionParameter parameter) {
}
@Override
public void parameterValueChanged(FilterDimensionParameter parameter, Iterable<? extends Serializable> oldValues) {
report.adjustAllDimensionFiltersInQueriesUsingParameter(parameter);
}
}