eclipse-sailing-analytics/sailing-analytics
1
0 Fork 0
mirror of https://github.com/eclipse-sailing-analytics/sailing-analytics.git synced 2026-11-14 22:43:57 +00:00
Code Activity

bug5178: adding necessary wait for new removal alert dialog

Browse Source
This commit is contained in:
Axel Uhl committed 2020-04-15 02:49:11 +02:00
1 parent 1ff519231a
commit ef065feff7
2 files changed
+6 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/PageObject.java
+5 -6
View File
@@ -304,8 +304,8 @@ public class PageObject {
* @return
* The first matching element in the given context.
*/
protected WebElement waitForElementBySeleniumId(SearchContext context, String id, int timeout) {
FluentWait<SearchContext> wait = createFluentWait(context, timeout, DEFAULT_POLLING_INTERVAL);
protected WebElement waitForElementBySeleniumId(SearchContext context, String id, int timeoutInSeconds) {
FluentWait<SearchContext> wait = createFluentWait(context, timeoutInSeconds, DEFAULT_POLLING_INTERVAL);
return (WebElement) wait.until(new Function<SearchContext, Object>() {
@Override
public Object apply(SearchContext context) {
@@ -514,13 +514,13 @@ public class PageObject {
*
* @param supplier {@link PageAreaSupplier} used to instantiate the {@link PageArea}
* @param seleniumId the selenium id of the desired element
* @param timeout the timeout in seconds to wait for the element
* @param timeoutInSeconds the timeout in seconds to wait for the element
* @return {@link PageArea} representing the first matching element
*
* @see #findElementBySeleniumId(SearchContext, String)
*/
protected <T extends PageArea> T waitForPO(PageAreaSupplier<T> supplier, String seleniumId, int timeout) {
return supplier.get(driver, waitForElementBySeleniumId(driver, seleniumId, timeout));
protected <T extends PageArea> T waitForPO(PageAreaSupplier<T> supplier, String seleniumId, int timeoutInSeconds) {
return supplier.get(driver, waitForElementBySeleniumId(driver, seleniumId, timeoutInSeconds));
}
/**
@@ -626,7 +626,6 @@ public class PageObject {
protected void waitForNotificationAndDismiss(int timeoutInSeconds, String expectedNotificationMessage) {
WebDriverWait wait = new WebDriverWait(driver, timeoutInSeconds);
wait.until(new Function<WebDriver, Boolean>() {
@Override
public Boolean apply(WebDriver t) {
boolean clickedNotifications = false;
java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/adminconsole/tracking/TrackedRacesListPO.java
+1
View File
@@ -174,6 +174,7 @@ public class TrackedRacesListPO extends PageArea {
private void removeSelectedTrackedRacesAndWaitForAjaxRequests() {
this.removeButton.click();
this.waitForAlertAndAccept();
waitForAjaxRequests();
}