Commit Graph
100 Commits
Author SHA1 Message Date
Steffen Schaefer 0388a7a8c0 Merge branch 'master' into bug5239 2020-09-14 16:32:39 +02:00
Steffen Schaefer d2887880c1 Removed unused import 2020-09-14 16:25:53 +02:00
Steffen Schaefer 880cad0ca9 Bug 5239: Removed unused imports 2020-09-14 16:19:06 +02:00
Steffen Schaefer 219bd486e3 Merge branch 'master' into bug5239 2020-09-14 16:04:10 +02:00
Steffen Schaefer ee60c50797 Bug 5239: Removed flags to deactivate negative ACLs 2020-09-14 16:03:28 +02:00
Steffen Schaefer 4fefa2d42a Merge branch 'master' into bug5239 2020-09-14 15:10:56 +02:00
Steffen Schaefer 133c63bfed Bug 5239: Removed trailing space 2020-09-11 09:51:54 +02:00
Steffen Schaefer 61a7de573e Bug 5239: Consistently use ConcurrentHashMap for
UserImpl.defaultTenantForServer (partially reverts a recent change)
2020-09-11 09:32:33 +02:00
Steffen Schaefer a677a5f566 Bug 5239: Code simplification 2020-09-11 09:04:00 +02:00
Steffen Schaefer 266a26a58b Bug 5239: Fixed potential NPE 2020-09-11 08:57:25 +02:00
Steffen Schaefer 2f6afe7609 Merge branch 'master' into bug5239 2020-09-07 18:28:03 +02:00
Steffen Schaefer 6ae1e6d2a3 Bug 5239: Using Map instead of HashMap where applicable 2020-09-07 17:58:25 +02:00
Steffen Schaefer 86ea6191f8 Bug 5239: Implemented proper locking in readResolve 2020-09-07 17:57:00 +02:00
Steffen Schaefer 33afaf8161 Bug 5239: Removed deleteUserGroup from UserStore API because it must not
be called from the outside to not leave broken relations
2020-09-07 17:48:15 +02:00
Steffen Schaefer e7f3a11cae Bug 5239: Using read lock where only reading from the preferences
collections
2020-09-07 17:41:25 +02:00
Steffen Schaefer 9ffcb815bd Bug 5239: Ensure unsetting preferences map per user if no preference
remains
2020-09-07 17:39:56 +02:00
Steffen Schaefer a6718028e5 Bug 5239: Only using locks if accessing colections 2020-09-07 17:36:12 +02:00
Steffen Schaefer f7193323f6 Bug 5239: Added missing write lock 2020-09-07 17:34:06 +02:00
Steffen Schaefer 026b3a77ad Bug 5239: Using write lock to guard usersByAccessToken changes 2020-09-07 17:32:06 +02:00
Steffen Schaefer 3a47d49a98 Bug 5239: Added missing write lock 2020-09-07 17:30:14 +02:00
Steffen Schaefer cd61117979 Bug 5239: Code formatting change 2020-09-07 17:29:28 +02:00
Steffen Schaefer afa86822e3 Bug 5239: Not using Concurrent collections where we use ReadWriteLocks
to guard accesses
2020-09-07 17:28:27 +02:00
Steffen Schaefer 7d9368d970 Bug 5239: Removed synchronized blocks that are now replaced with a
ReadWriteLock
2020-09-07 17:20:47 +02:00
Steffen Schaefer 98ae2df1f0 Bug 5239: Prevent repetitive lock/unlock 2020-09-07 17:17:08 +02:00
Steffen Schaefer ab0c6b94c7 Bug 5239: Changed lock objects in UserStoreImpl to be transient and
axplicitly handled during deserialization
2020-09-07 17:14:07 +02:00
Steffen Schaefer 2138a6671a Bug 5239: Improved locking in UserStoreImpl for several methods 2020-09-07 14:34:24 +02:00
Steffen Schaefer ff4e3ffc6d Bug 5239: Finding the correct permission entry by name in RoleDefinition
edit dialog
2020-09-07 08:57:06 +02:00
Steffen Schaefer 9d67fef062 Bug 5239: Fixed reading the value in TextBoxBasePO 2020-09-07 08:55:41 +02:00
Steffen Schaefer 86c0dab517 Bug 5239: Changed StringListEditorCompositePO to throw an exception if
the value to be removed wasn't found.
2020-09-04 13:17:12 +02:00
Steffen Schaefer 03022fd382 Bug 5239: Extended more of the negative ACL tests to ensure that
negative ACLs are also part of the meta permission check when removing
a permission from a role
2020-08-28 09:44:39 +02:00
Steffen Schaefer 3ba28081c2 Bug 5239: Changed expected permission error when saving a Role to also
match cases where revoking a permission causes an error
2020-08-28 09:32:02 +02:00
Steffen Schaefer dbaae279b0 Merge branch 'master' into bug5239 2020-08-28 08:41:08 +02:00
Steffen Schaefer db7a28d843 Merge branch 'master' into bug5315 2020-08-21 09:25:42 +02:00
Steffen Schaefer 39c98d577f Bug 5239: Adjusted comment 2020-08-20 12:57:40 +02:00
Steffen Schaefer e272a51dff Bug 5239: Extended more of the negative ACL tests to ensure that
negative ACLs are also part of the meta permission check when removing
permissions/roles
2020-08-20 12:55:20 +02:00
Steffen Schaefer 93eef5678a Bug 5239: Extended UserGroupRoleDefinitionPanelPO to be able to expect
an error when trying to remove a Role from a UserGroup
2020-08-20 12:53:57 +02:00
Steffen Schaefer 8ee184e990 Bug 5239: Changed removal of a Role from a UserGroup to be symmetric
regarding permission checks of adding a Role
2020-08-20 12:53:20 +02:00
Steffen Schaefer dd73f633ee Bug 5239: Extended UserGroupUserPanelPO to be able to expect an
error when trying to remove a User for a UserGroup
2020-08-20 12:36:44 +02:00
Steffen Schaefer 9ad1364cd6 Bug 5239: Changed removal of a User from a UserGroup to be symmetric
regarding permission checks with adding a User
2020-08-20 11:39:05 +02:00
Steffen Schaefer 99dde9e113 Merge branch 'master' into bug5239 2020-08-20 10:44:16 +02:00
Steffen Schaefer 090c4f4041 Bug 5239: Extended parts of the negative ACL tests to ensure that
negative ACLs are also part of the meta permission check when removing
permissions/roles
2020-08-20 10:43:20 +02:00
Steffen Schaefer 8c3168fd82 Bug 5239: Extended WildcardPermissionPanelPO to be able to expect an
error when trying to remove a permission from a user
2020-08-20 10:41:21 +02:00
Steffen Schaefer 9cdebf8e49 Bug 5239: Implemented meta permission check when removing a permission
from a user
2020-08-20 10:40:44 +02:00
Steffen Schaefer b04d954567 Bug 5239: Renamed internal method to make clear what happens inside 2020-08-20 10:35:01 +02:00
Steffen Schaefer 5b561f43ac Bug 5239: Implemented additional wait when saving ACLs 2020-08-20 10:29:27 +02:00
Steffen Schaefer 1051a02eb3 Bug 5239: Extended UserRoleDefinitionPanelPO to be able to expect an
permission error when trying to remove a role from a user
2020-08-20 10:29:00 +02:00
Steffen Schaefer f16f3b722e Typo fix 2020-08-20 10:01:33 +02:00
Steffen Schaefer 56733ffaf6 Bug 5239: Added Locks for users and userGroups in UserStoreImpl to guard
operations that read/write to multiple UserStore Collections. Not all
methods are currently using those locks.
2020-08-19 14:54:06 +02:00
Steffen Schaefer 5542c7cfb4 Merge branch 'master' into bug5239 2020-08-19 12:36:27 +02:00
Steffen Schaefer 3afdbaff38 Merge branch 'master' into bug5239 2020-08-19 09:54:54 +02:00
Steffen Schaefer 5daa2988dd Bug 5239: Introduced an association of RoleDefinition to Users and
UserGroups having this RoleDefinition
2020-08-19 09:54:23 +02:00
Steffen Schaefer 6822e1338c Bug 5239: Fixed selenium test failures on Hudson by explicitly
dismissing notifications that may cover buttons in dialogs due to
limited screen height on Hudson
2020-08-18 09:10:13 +02:00
Steffen Schaefer 4b7060a967 Merge branch 'master' into bug5239 2020-08-18 08:42:21 +02:00
Steffen Schaefer 4243fdf6fc Bug 5239: Reduced code duplications 2020-08-18 08:41:58 +02:00
Steffen Schaefer a0f671fc55 Merge branch 'master' into bug5239 2020-08-17 16:16:38 +02:00
Steffen Schaefer bf898b59fc Bug 5239: Ensures that roles associated to a UserGroup are also part of
the meta permission check when changing the permissions of a
RoleDefinition.
2020-08-17 16:13:23 +02:00
Steffen Schaefer 9e416bb304 Bug 5239: Finished and activated test to check that negative ACLs
prevent
adding a permission to a role. This is a failing test by now and proofs
that there is a bug in the backend implementation.
2020-08-17 16:12:15 +02:00
Steffen Schaefer 48dac7bae2 Bug 5239: Removed code duplication 2020-08-17 16:05:12 +02:00
Steffen Schaefer 73b9930baf Bug 5239: Added missing import 2020-08-17 12:03:50 +02:00
Steffen Schaefer a2cae295f2 Bug 5239: Resolved TODOs by adding asserts to check the final
state
2020-08-17 12:01:51 +02:00
Steffen Schaefer 12d022a9cb Bug 5239: Added new test case to check that negative ACLs prevent
adding a permission to a Role that is already granted to a user
2020-08-17 11:18:59 +02:00
Steffen Schaefer d6f720a5e0 Bug 5239: Added PO for the generic error dialog 2020-08-17 11:05:07 +02:00
Steffen Schaefer 46753a3b68 Merge branch 'master' into bug5239 2020-08-17 09:55:09 +02:00
Steffen Schaefer 5c23e1ae5d Bug 5239: Added non working (ignored) test to check that negative ACLs
prevent
adding a permission to a role
2020-08-14 16:05:15 +02:00
Steffen Schaefer 6d311301ad Bug 5239: Removed unused method 2020-08-14 16:01:17 +02:00
Steffen Schaefer a8561d215c Bug 5239: Extended POs to allow editing RoleDefinitions 2020-08-14 15:53:22 +02:00
Steffen Schaefer 67a72a2045 Bug 5239: Introduced DataEntryWithSecurityActionsPO abstract superlclass
for CellTable entries to generically support change ACL dialog in
CellTables via Selenium
2020-08-14 15:52:42 +02:00
Steffen Schaefer 57145f3c46 Bug 5239: Removed a comment that isn't valid after refactoring 2020-08-14 13:57:32 +02:00
Steffen Schaefer 7d2026251e Bug 5239: Resolved several TODOs by adding asserts to check the final
state
2020-08-14 13:54:46 +02:00
Steffen Schaefer 22bd55040d Merge branch 'master' into bug5239 2020-08-14 13:42:07 +02:00
Steffen Schaefer 86759834c4 Bug 5239: Added initial test case to check that negative ACLs prevent
adding a role to a UserGroup
2020-08-14 13:41:30 +02:00
Steffen Schaefer 1a4dcd577e Bug 5239: Improved comment in test case 2020-08-14 12:45:25 +02:00
Steffen Schaefer 63f198ac9f Bug 5239: Changed expected error message when trying to add a Role to a
UserGroup
2020-08-14 12:44:02 +02:00
Steffen Schaefer 9d9dfed7f2 Bug 5239: Extended UserManagementPanelPO to be able to add a role with
group qualification
2020-08-14 12:43:01 +02:00
Steffen Schaefer cba99c5c34 Bug 5239: Fixed construction of a role String when waiting for a Role to
appear in the table
2020-08-14 12:42:23 +02:00
Steffen Schaefer 399f5a60ab Bug 5239: Added initial test case to check that negative ACLs prevent
adding a user to a UserGroup
2020-08-14 11:31:33 +02:00
Steffen Schaefer 01cd77dac2 Bug 5239: Added TODOs and improved inline comments 2020-08-14 11:25:43 +02:00
Steffen Schaefer 32595a3c81 Bug 5239: Extended the test cases regarding negative ACLs to check the
positive case for a user who is not affected by the negative ACL
2020-08-12 15:52:55 +02:00
Steffen Schaefer 6546284270 Bug 5239: Clear username textbox before searching for another one 2020-08-12 15:51:43 +02:00
Steffen Schaefer 5adf8b8de2 Bug 5239: Added TODO 2020-08-12 15:51:04 +02:00
Steffen Schaefer fb6fda6bd4 Bug 5239: Implemented proper wait when adding roles or permissions to a
user / removed Thread.sleep that is now obsolete
2020-08-12 14:40:05 +02:00
Steffen Schaefer 1efe7be458 Bug 5239: Added several convenience methods to add roles or permissions
to a user
2020-08-12 14:40:02 +02:00
Steffen Schaefer 8f00d18780 Bug 5239: Improved field and method naming 2020-08-12 13:49:25 +02:00
Steffen Schaefer 2b742bb42d Bug 5239: Removed PO from methods 2020-08-12 13:47:21 +02:00
Steffen Schaefer 9cc6d56ab0 Bug 5239: Added initial test case to check that negative ACLs prevent
adding a direct permission to a user
2020-08-12 13:46:04 +02:00
Steffen Schaefer ad181f0418 Bug 5239: Using factory methods to properly wait for POs 2020-08-12 13:45:04 +02:00
Steffen Schaefer da76c46e3f Bug 5239: Added more convenience methods to PageObject to get a PO or
wait for a PO
2020-08-12 13:43:59 +02:00
Steffen Schaefer 3f7b17c3f9 Bug 5239: Added the possibility to get the UUID of an event via PO 2020-08-12 13:42:53 +02:00
Steffen Schaefer c873929e24 Bug 5239: Added the possibility to expect an permission error when
trying to add a permission to a user
2020-08-12 13:42:17 +02:00
Steffen Schaefer 07acedaa72 Bug 5239: Consistent method naming 2020-08-12 13:23:47 +02:00
Steffen Schaefer be7fd179f0 Bug 5239: Added TODO 2020-08-12 12:59:32 +02:00
Steffen Schaefer 00156b10ad Bug 5239: Added documentation 2020-08-12 12:55:47 +02:00
Steffen Schaefer c8ef26f7e4 Bug 5239: Added initial test case to check that negative ACLs prevent
adding a role to a user
2020-08-12 10:59:03 +02:00
Steffen Schaefer 6662303d31 Bug 5239: Added the possibility to expect an permission error when
trying to add a role to a user
2020-08-12 10:58:15 +02:00
Steffen Schaefer d086cebcd8 Bug 5239: Added the possibility to open the "Edit roles and permissions
for user" dialog in selenium tests
2020-08-12 10:57:26 +02:00
Steffen Schaefer 49b1d7475a Bug 5239: Fixed NPE when resolving ACLs in meta permission check 2020-08-12 10:26:28 +02:00
Steffen Schaefer 74e6e3c306 Bug 5239: It is now possible to log in as another user in selenium tests 2020-08-12 10:25:57 +02:00
Steffen Schaefer 407436074b Bug 5239: Added convenience methods to POs 2020-08-12 10:25:12 +02:00
Steffen Schaefer 1be86ae14c Bug 5239: Made PO method visible to tests 2020-08-12 10:24:28 +02:00
Steffen Schaefer 7d1445672a Bug 5239: Added the possibility to control more options of the local
server tab via page object
2020-08-12 10:24:05 +02:00