espressif/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2026-04-27 11:03:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tcp_transport): reset state on async TLS connect failure to avoid use-after-free

Browse Source
This commit is contained in:
nilesh.kale
2026-03-18 11:56:29 +05:30
parent 71b9c4247c
commit 8a37408fa7
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/tcp_transport/transport_ssl.c
+9 -1
View File
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: 2015-2025 Espressif Systems (Shanghai) CO LTD
* SPDX-FileCopyrightText: 2015-2026 Espressif Systems (Shanghai) CO LTD
*
* SPDX-License-Identifier: Apache-2.0
*/
@@ -71,6 +71,8 @@ static int esp_tls_connect_async(esp_transport_handle_t t, const char *host, int
ssl->ssl_initialized = true;
ssl->tls = esp_tls_init();
if (!ssl->tls) {
ESP_LOGE(TAG, "Failed to initialize TLS");
ssl->ssl_initialized = false;
return -1;
}
ssl->conn_state = TRANS_SSL_CONNECTING;
@@ -82,6 +84,10 @@ static int esp_tls_connect_async(esp_transport_handle_t t, const char *host, int
if (esp_tls_get_conn_sockfd(ssl->tls, &ssl->sockfd) != ESP_OK) {
ESP_LOGE(TAG, "Error in obtaining socket fd for the session");
esp_tls_conn_destroy(ssl->tls);
ssl->tls = NULL;
ssl->conn_state = TRANS_SSL_INIT;
ssl->ssl_initialized = false;
ssl->sockfd = INVALID_SOCKET;
return -1;
}
}
@@ -112,6 +118,7 @@ static int ssl_connect(esp_transport_handle_t t, const char *host, int port, int
ssl->tls = esp_tls_init();
if (ssl->tls == NULL) {
ESP_LOGE(TAG, "Failed to initialize new connection object");
ssl->ssl_initialized = false;
capture_tcp_transport_error(t, ERR_TCP_TRANSPORT_NO_MEM);
return -1;
}
@@ -135,6 +142,7 @@ static int ssl_connect(esp_transport_handle_t t, const char *host, int port, int
exit_failure:
esp_tls_conn_destroy(ssl->tls);
ssl->tls = NULL;
ssl->ssl_initialized = false;
ssl->sockfd = INVALID_SOCKET;
return -1;
}