espressif/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2026-04-27 19:13:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Add quotes around node ID in dependency graph

Browse Source 
Graphviz node ID's are represented as strings, that can only use a
restricted set of characters (characters, digits, and underscores), and
must not match a reserved keyword. These restrictions do not apply when
the string is wrapped in double quotes. This allows for component names
with dashes in them, for example.

Closes https://github.com/espressif/esp-idf/pull/17594
This commit is contained in:
Vincent-Dalstra
2025-09-17 14:48:39 +08:00
committed by BOT
parent 08e4aba740
commit a36c8b8725
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/cmake/depgraph.cmake
+2 -2
View File
@@ -35,10 +35,10 @@ function(depgraph_add_edge dep_from dep_to)
# However, show which components are "common" by adding an edge from a node named "common".
# If necessary, add a new build property to customize this behavior.
if(NOT dep_from IN_LIST common_reqs)
idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "common -> ${dep_to}" APPEND)
idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "\"common\" -> \"${dep_to}\"" APPEND)
endif()
else()
idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "${dep_from} -> ${dep_to} ${attr}" APPEND)
idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "\"${dep_from}\" -> \"${dep_to}\" ${attr}" APPEND)
endif()
endfunction()