espressif/esp-matter
1
0
Fork 0
mirror of https://github.com/espressif/esp-matter.git synced 2026-04-27 19:13:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

components/esp_matter: move air quality attribute storage to external

Browse Source 
Storage of this attribute was moved from esp-matter to
connectedhomeip during the v1.4.2 release by implementing the AAI in
connectedhomeip. For most clusters, AAI registration occurs in the
cluster-init callback, but for this Air Quality cluster, it is
delegated to the application layer. So, in the esp-matter's workflow,
no one registers the AAI. And, as this attribute is of primitive type,
we can discard the ATTRIBUTE_FLAG_MANAGED_INTERNALLY flag and storage
can be managed by esp-matter.
This commit is contained in:
Shubham Patil
2025-10-09 17:15:15 +05:30
parent 77cce487eb
commit 37a2c7d0b7
3 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/esp_matter/data_model/esp_matter_attribute.cpp
+7 -1
View File
@@ -2347,7 +2347,13 @@ namespace attribute {
attribute_t *create_air_quality(cluster_t *cluster, uint8_t value)
{
return esp_matter::attribute::create(cluster, AirQuality::Attributes::AirQuality::Id, ATTRIBUTE_FLAG_MANAGED_INTERNALLY,
// Storage of this attribute was moved from esp-matter to connectedhomeip during the v1.4.2 release by
// implementing the AAI in connectedhomeip.
// For most clusters, AAI registration occurs in the cluster-init callback, but for this cluster,
// it is delegated to the application layer. So, in the esp-matter's workflow, no one registers the AAI.
// And, as this attribute is of primitive type, we can discard the ATTRIBUTE_FLAG_MANAGED_INTERNALLY flag
// and storage can be managed by esp-matter.
return esp_matter::attribute::create(cluster, AirQuality::Attributes::AirQuality::Id, ATTRIBUTE_FLAG_NONE,
esp_matter_enum8(value));
}
components/esp_matter/data_model/esp_matter_cluster.cpp
+1 -1
View File
@@ -1403,7 +1403,7 @@ cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags)
/* Attributes managed internally */
global::attribute::create_feature_map(cluster, 0);
attribute::create_air_quality(cluster, 0);
attribute::create_air_quality(cluster, config->air_quality);
/* Attributes not managed internally */
global::attribute::create_cluster_revision(cluster, cluster_revision);
components/esp_matter/data_model/esp_matter_cluster.h
+4 -1
View File
@@ -354,7 +354,10 @@ cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags);
} /* thermostat_user_interface_configuration */
namespace air_quality {
using config_t = common::config_t;
typedef struct config {
uint8_t air_quality;
config() : air_quality(0) {}
} config_t;
cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags);
} /* air_quality */