espressif/esp-matter
1
0
Fork 0
mirror of https://github.com/espressif/esp-matter.git synced 2026-04-27 19:13:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

resolve some comment

Browse Source
This commit is contained in:
liyashuai
2024-02-28 17:18:46 +08:00
parent d7a5642451
commit bc55974f34
3 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/esp_matter/esp_matter_attribute.cpp
+5 -5
View File
@@ -283,7 +283,7 @@ attribute_t *create_specification_version(cluster_t *cluster, uint32_t value)
esp_matter_uint32(value));
}
attribute_t *create_max_path_per_invoke_version(cluster_t *cluster, uint16_t value)
attribute_t *create_max_paths_per_invoke(cluster_t *cluster, uint16_t value)
{
return esp_matter::attribute::create(cluster, BasicInformation::Attributes::MaxPathsPerInvoke::Id, ATTRIBUTE_FLAG_NONE,
esp_matter_uint16(value));
@@ -1067,22 +1067,22 @@ attribute_t *create_group_name_support(cluster_t *cluster, uint8_t value)
namespace scenes_management {
namespace attribute {
attribute_t *create_last_configure_by(cluster_t *cluster, uint64_t value)
attribute_t *create_last_configured_by(cluster_t *cluster, uint64_t value)
{
return esp_matter::attribute::create(cluster, ScenesManagement::Attributes::LastConfiguredBy::Id, ATTRIBUTE_FLAG_NONE,
esp_matter_uint64(value));
esp_matter_uint64(value));
}
attribute_t *create_scene_table_size(cluster_t *cluster, uint16_t value)
{
return esp_matter::attribute::create(cluster, ScenesManagement::Attributes::SceneTableSize::Id, ATTRIBUTE_FLAG_NONE,
esp_matter_uint16(value));
esp_matter_uint16(value));
}
attribute_t *create_fabric_scene_info(cluster_t *cluster, const uint8_t * value, uint16_t length, uint16_t count)
{
return esp_matter::attribute::create(cluster, ScenesManagement::Attributes::FabricSceneInfo::Id, ATTRIBUTE_FLAG_NONE,
esp_matter_array((uint8_t*)value, length, count));
esp_matter_array((uint8_t*)value, length, count));
}
} /* attribute */
components/esp_matter/esp_matter_attribute.h
+2 -2
View File
@@ -92,7 +92,7 @@ attribute_t *create_reachable(cluster_t *cluster, bool value);
attribute_t *create_unique_id(cluster_t *cluster, char *value, uint16_t length);
attribute_t *create_product_appearance(cluster_t *cluster, uint8_t *value, uint16_t length, uint16_t count);
attribute_t *create_specification_version(cluster_t *cluster, uint32_t value);
attribute_t *create_max_path_per_invoke_version(cluster_t *cluster, uint16_t value);
attribute_t *create_max_paths_per_invoke(cluster_t *cluster, uint16_t value);
} /* attribute */
} /* basic_information */
@@ -303,7 +303,7 @@ attribute_t *create_group_name_support(cluster_t *cluster, uint8_t value);
namespace scenes_management {
namespace attribute {
attribute_t *create_last_configure_by(cluster_t *cluster, uint64_t value);
attribute_t *create_last_configured_by(cluster_t *cluster, uint64_t value);
attribute_t *create_scene_table_size(cluster_t *cluster, uint16_t value);
attribute_t *create_fabric_scene_info(cluster_t *cluster, const uint8_t * value, uint16_t length, uint16_t count);
} /* attribute */
components/esp_matter/esp_matter_cluster.cpp
+4 -5
View File
@@ -241,7 +241,7 @@ cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags)
attribute::create_software_version_string(cluster, NULL, 0);
attribute::create_capability_minima(cluster, NULL, 0, 0);
attribute::create_specification_version(cluster, 0);
//attribute::create_max_path_per_invoke_version(cluster, 0);
attribute::create_max_paths_per_invoke(cluster, 0);
/* Attributes not managed internally */
if (config) {
@@ -594,7 +594,6 @@ cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags, uint32_
/* Commands */
command::create_open_commissioning_window(cluster);
//command::create_open_basic_commissioning_window(cluster);
command::create_revoke_commissioning(cluster);
return cluster;
@@ -998,12 +997,12 @@ cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags, uint32_
}
}
#if CHIP_CONFIG_ENABLE_ICD_CIP
#if defined(CHIP_CONFIG_ENABLE_ICD_CIP) && CHIP_CONFIG_ENABLE_ICD_CIP
if (features & feature::check_in_protocol_support::get_id()) {
feature::check_in_protocol_support::config_t cip_config;
feature::check_in_protocol_support::add(cluster, &cip_config);
}
#endif // CHIP_CONFIG_ENABLE_ICD_CIP
#endif // defined(CHIP_CONFIG_ENABLE_ICD_CIP) && CHIP_CONFIG_ENABLE_ICD_CIP
#endif // CONFIG_ENABLE_ICD_SERVER
return cluster;
}
@@ -1215,7 +1214,7 @@ cluster_t *create(endpoint_t *endpoint, config_t *config, uint8_t flags)
/* Attributes not managed internally */
if (config) {
global::attribute::create_cluster_revision(cluster, config->cluster_revision);
attribute::create_last_configure_by(cluster, 0);
attribute::create_last_configured_by(cluster, 0);
attribute::create_scene_table_size(cluster, config->scene_table_size);
attribute::create_fabric_scene_info(cluster, NULL, 0, 0);
} else {