mirror of
https://github.com/eclipse-sailing-analytics/sailing-analytics.git
synced 2026-11-04 10:09:42 +00:00
changes made per Axel Claude Code review
problem: MiscellaneousDisplayImpl.wrapCallbackWithToastResponse callback.onSuccess called twice fix: removed the call without null check problem: arbitrary comments in UserPreferences fix: removed comments problem: RuntimeException thrown in UserPreferencesPresenter discuss: why is this a problem problem: CheckBoxTile.gss @keyframes spin formatting discuss: looks okay to me unrelated change: removed commented-out code problem: injection of CheckBoxTileResources was not needed in LabeledBox fix: injection was removed from here and shifted appropriately to CheckBoxTile
This commit is contained in:
1 parent
7e5331a0c0
commit
15d6fbbdeb
5 files changed
+3
-10
No files matched your search
+1
-4
@@ -4,16 +4,13 @@
|
||||
align-items: center;
|
||||
gap: 0.5em;
|
||||
padding: 0.333333333333333em;
|
||||
/* position: relative; */
|
||||
}
|
||||
|
||||
.checkbox {
|
||||
position: relative;
|
||||
display: inline-flex;
|
||||
align-items: center;
|
||||
justify-content: center; /*
|
||||
right: 0.333333333333333em;
|
||||
top: 0.333333333333333em; */
|
||||
justify-content: center;
|
||||
width: 2em;
|
||||
height: 2em;
|
||||
}
|
||||
|
||||
+1
@@ -38,6 +38,7 @@ public final class CheckBoxTile extends Composite implements HasValue<Boolean> {
|
||||
public CheckBoxTile(final String label, final boolean initialState,
|
||||
final BiConsumer<Boolean, AsyncCallback<VoidResult>> onToggle) {
|
||||
super();
|
||||
CheckBoxTileResources.INSTANCE.css().ensureInjected();
|
||||
initWidget(uiBinder.createAndBindUi(this));
|
||||
labelUi.setText(label);
|
||||
initToggleButtonUi(initialState, onToggle);
|
||||
|
||||
+1
-3
@@ -6,21 +6,19 @@ import com.google.gwt.uibinder.client.UiBinder;
|
||||
import com.google.gwt.uibinder.client.UiField;
|
||||
import com.google.gwt.user.client.ui.Composite;
|
||||
import com.google.gwt.user.client.ui.Widget;
|
||||
import com.sap.sailing.gwt.home.shared.partials.checkboxtile.CheckBoxTileResources;
|
||||
|
||||
public class LabeledBox extends Composite {
|
||||
@UiField
|
||||
SpanElement headerTitleUi;
|
||||
@UiField(provided = true)
|
||||
Widget childUi;
|
||||
|
||||
|
||||
private static LabeledBoxUiBinder uiBinder = GWT.create(LabeledBoxUiBinder.class);
|
||||
|
||||
interface LabeledBoxUiBinder extends UiBinder<Widget, LabeledBox> {
|
||||
}
|
||||
|
||||
public LabeledBox(final String title, final Widget childUi) {
|
||||
CheckBoxTileResources.INSTANCE.css().ensureInjected();
|
||||
this.childUi = childUi;
|
||||
initWidget(uiBinder.createAndBindUi(this));
|
||||
headerTitleUi.setInnerText(title);
|
||||
|
||||
-1
@@ -48,7 +48,6 @@ public class MiscellaneousDisplayImpl {
|
||||
.youWillNotReceiveFeatureAndCommunityUpdatesAnymore();
|
||||
final String message = isNowTrue ? passAndTrue : passAndFalse;
|
||||
Notification.notify(message, NotificationType.SUCCESS);
|
||||
callback.onSuccess(result);
|
||||
if (callback != null) {
|
||||
callback.onSuccess(result);
|
||||
}
|
||||
|
||||
-2
@@ -54,9 +54,7 @@ public class UserPreferences extends Composite implements UserPreferencesView {
|
||||
}
|
||||
|
||||
public void setEdgeToEdge(boolean edgeToEdge) {
|
||||
// favoriteBoatClassesSelctionUi.setStyleName(style.edgeToEdge(), edgeToEdge);
|
||||
favoriteCompetitorsSelctionUi.setStyleName(style.edgeToEdge(), edgeToEdge);
|
||||
// favoriteBoatClassesSelctionUi.getElement().getParentElement().removeClassName(res.mediaCss().column());
|
||||
favoriteCompetitorsSelctionUi.getElement().getParentElement().removeClassName(res.mediaCss().column());
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user