Commit Graph
100 Commits
Author SHA1 Message Date
Steffen Schaefer 29fa3bc38f Adjusted RegattaOverview to use Lifecycle/ComponentContext for handling
of settings
2017-02-20 08:28:44 +01:00
Steffen Schaefer e39fc2cee8 The regular SettingsDialog can now optionally create links 2017-02-20 08:28:39 +01:00
Steffen Schaefer cf43a62842 Pulled handling of initial settings into ComponentContext interface and
simplified its usage
2017-02-20 08:28:35 +01:00
Steffen Schaefer c15bbc0fef Renamed AbstractComponentContextWithSettingsStorage to
ComponentContextWithSettingsStorage because it isn't abstract anymore
2017-02-15 11:00:58 +01:00
Steffen Schaefer 1e4dec6f70 Using interface reference where possible 2017-02-15 10:59:40 +01:00
Steffen Schaefer 4b1f5107f2 Pulled initInitialSettings method up into ComponentContext interface to
handle the simple case without settings storage equally (to ease future
updates)
2017-02-15 10:59:26 +01:00
Steffen Schaefer 25b6a52621 Removed unused classes 2017-02-15 10:55:56 +01:00
Steffen Schaefer d91c0d78a2 Added missing generics 2017-02-15 10:06:59 +01:00
Steffen Schaefer 4916a217bb Merge branch 'master' into bug3529 2017-02-15 09:58:01 +01:00
Steffen Schaefer 4392c35fb5 Adjusted LeaderboardEditing to have a Layout based on DockLayoutPanel
(this is how Leaderboard is layouted) and fixed the CSS to reliably work
for both entry points and embedded mode of Leaderboard
2017-02-15 09:32:21 +01:00
Steffen Schaefer bcdcd85d62 Using flat keys instead of '_' for perspective own settings 2017-02-14 17:57:56 +01:00
Steffen Schaefer 12e7ce5575 Using real settings objects to construct Leaderboard.html links 2017-02-14 16:20:30 +01:00
Steffen Schaefer 052e4cc1fc Removed unused generic 2017-02-14 16:19:31 +01:00
Steffen Schaefer f185942f12 Refactored entrypoint path to a constant to reduce duplications 2017-02-14 16:19:07 +01:00
Steffen Schaefer a11440be04 Removed constants that are only used in one settings object 2017-02-14 15:47:50 +01:00
Steffen Schaefer 4c6d70dca9 Removed unused code 2017-02-14 15:39:24 +01:00
Steffen Schaefer cbb567c8d3 Fixed inconsistencies of component hierarchy of LeaderboardViewer and
MetaLeaderboardViewer
2017-02-14 15:21:26 +01:00
Steffen Schaefer 90a239172b Reduced code duplications and ensuring consistency regarding defaults
for LeaderboardSettings
2017-02-14 14:56:11 +01:00
Steffen Schaefer c5e1d16ac2 Changed MultiCompetitorLeaderboardChart settings component to show the
DetailType selection based on the leaderboard type
2017-02-14 13:10:58 +01:00
Steffen Schaefer 7153165edd Merge branch 'master' into bug3529 2017-02-14 11:34:44 +01:00
Steffen Schaefer 3d410bb30a Only allowing chart types that are available for the leaderboard type 2017-02-14 11:20:50 +01:00
Steffen Schaefer 9f47868fc2 Using constant instead of hard-coded ID for
MultiCompetitorLeaderboardChart settings
2017-02-14 10:59:03 +01:00
Steffen Schaefer 1d7a5ef098 Fixed NPE 2017-02-14 10:58:59 +01:00
Steffen Schaefer bcd7fc35cb Code simplifications 2017-02-14 10:58:55 +01:00
Steffen Schaefer 92974ef001 Removed manual parsing of URL parameter chartDetail. Using it from the
deserialized settings instead
2017-02-14 10:58:52 +01:00
Steffen Schaefer 3627a11369 Moved embedded setting to LeaderboardPerspectiveOwnSettings and
restructured the code to create the LeaderboardEntryPoint UI after the
settings are available
2017-02-14 10:13:35 +01:00
Steffen Schaefer aedf7c3b34 Removed fields that aren't needed at all 2017-02-14 09:59:17 +01:00
Steffen Schaefer cf3cb0931b Cloning settings isn't needed anymore because Settings are expected to
be immutable
2017-02-14 09:41:27 +01:00
Steffen Schaefer 421828aace Added zoomTo to LeaderboardPerspectiveOwnSettings 2017-02-14 09:17:37 +01:00
Steffen Schaefer f072950d50 LeaderboardSettings from the URL aren't parsed manually anymore 2017-02-14 08:50:48 +01:00
Steffen Schaefer e3393c5557 First (non-working) changes to use lifecycle/settings framework for
Leaderboard.html link creation in AdminConsole
2017-02-13 10:41:37 +01:00
Steffen Schaefer 3267456e6e Moved link sharing logic out of ComponentContext 2017-02-13 10:40:11 +01:00
Steffen Schaefer 9a01513ded Temporarily deactivated SettingsTest (will be activated again when
settings implementation is finished)
2017-02-09 14:53:26 +01:00
Steffen Schaefer ea63eb7109 Refactoring of SettingsDialog inheritance to have distinct classes for
different use-cases
2017-02-09 11:13:20 +01:00
Steffen Schaefer 9a0cbf90d8 Merge branch 'master' into bug3529 2017-02-09 10:29:16 +01:00
Steffen Schaefer 79a8184d04 Added first parts for link sharing via SettingsDialog 2017-02-09 10:28:25 +01:00
Steffen Schaefer 171983bd5f SettingsDialog can also be called with a ComponentLifecycle instance 2017-02-09 09:24:20 +01:00
Steffen Schaefer 58b1aa15c0 Merge branch 'master' into bug3529 2017-02-09 08:53:06 +01:00
Steffen Schaefer 8519de465d First stub for link generation using ComponentContext 2017-02-09 08:52:37 +01:00
Steffen Schaefer 7818a9fd4a First stub for link generation using ComponentContext 2017-02-08 15:25:41 +01:00
Steffen Schaefer 22c369eba0 Merge branch 'master' into bug3529 2017-02-08 08:19:12 +01:00
Steffen Schaefer e3280d7609 Code style improvements 2017-02-07 11:22:47 +01:00
Steffen Schaefer a12e9c2637 Calling overwritable methods during object construction is an
antipattern. Using on the fly object creation instead.
2017-02-07 11:09:56 +01:00
Steffen Schaefer 6a2d4ae6fb Added more getters for measures to BravoFix 2017-02-07 09:42:07 +01:00
Steffen Schaefer 9b206a93cd Removed AsyncCallback that only delegates to a given AsyncCallback 2017-02-06 13:52:33 +01:00
Steffen Schaefer 0fa0e3cb6a Merge branch 'master' into bug3529 2017-02-06 11:58:09 +01:00
Steffen Schaefer fbfae35264 Bug 4052: SensorFixTracks are only added for available Competitors 2017-02-06 09:19:54 +01:00
Steffen Schaefer a286b407f5 Bug 4052: added failing test 2017-02-06 09:11:06 +01:00
Steffen Schaefer 62c2fec682 Merge branch 'master' into bug4009 2017-02-03 08:16:01 +01:00
Steffen Schaefer bcabc7b592 Fixed ClassCastExceptions when loading GPSFixes for Marks 2017-02-02 10:57:14 +01:00
Steffen Schaefer 1ca55a2d05 Using GPSFix instead of GPSFixMoving for Mark related tests. This
uncovers a ClassCastException that is caused in a real-world scenario
with the changes of commit 32995da2a6.
2017-02-02 10:56:38 +01:00
Steffen Schaefer 5afa162d16 Added test case for Util.group 2017-02-01 13:52:11 +01:00
Steffen Schaefer dce038e662 Added JavaDocs 2017-02-01 13:18:15 +01:00
Steffen Schaefer c5d4abdf93 Additional test case to ensure that only the best fixes for marks are
used if multiple mappings exist
2017-02-01 13:13:02 +01:00
Steffen Schaefer e327b3ea8c Code cleanup 2017-02-01 12:38:04 +01:00
Steffen Schaefer 0df6a53bdf Added more documentation / code formatting 2017-02-01 11:59:35 +01:00
Steffen Schaefer 24936bbeed Removed unused code 2017-02-01 11:35:45 +01:00
Steffen Schaefer eaf596cf3d Changes to only load the best fixes for mark tracks if there are no
fixes found in the tracking interval
2017-02-01 08:57:44 +01:00
Steffen Schaefer 354d313fdf Ensuring that better fallback fixes are always loaded for mark tracks
(not only if there is no fix present at all)
2017-02-01 08:57:00 +01:00
Steffen Schaefer b1afd5f5e7 Added functionality to SensorFixStore to load a single youngest or
oldest fix in a specific time range (this is needed to further optimize
loading of mark fixes out of the tracking time range)
2017-02-01 08:38:21 +01:00
Steffen Schaefer 4bdd6420ec Merge branch 'master' into bug4009 2017-01-31 14:35:54 +01:00
Steffen Schaefer a29f3bb5e7 Removed unused code 2017-01-31 14:30:35 +01:00
Steffen Schaefer 32995da2a6 Adjusted device mapping update to work incrementally for overlapping
mappings
2017-01-31 14:30:09 +01:00
Steffen Schaefer b55cf38599 Added a util method to group values of an Iterable by a specific key 2017-01-31 10:12:39 +01:00
Steffen Schaefer 1633275af0 Added more convenience methods to LockUtil for cases where you need to
return a value while being under a lock
2017-01-31 10:10:37 +01:00
Steffen Schaefer b506d1f81d Removed unused code 2017-01-30 17:10:57 +01:00
Steffen Schaefer 3acb4fbcd1 Merge branch 'master' into bug4009 2017-01-27 09:05:20 +01:00
Steffen Schaefer 86ae110571 Merge branch 'master' into bug4009 2017-01-26 15:31:34 +01:00
Steffen Schaefer 79bd973cd0 Merge branch 'bug4039' 2017-01-26 15:26:50 +01:00
Steffen Schaefer 674920138a bug 4041: Ensuring that exceptions during device mapping updates are
correctly handled
2017-01-26 14:12:12 +01:00
Steffen Schaefer 84cf4dd574 bug 4041: It doesn't make sense to call mappingsAdded if the collection
of added mappings is empty
2017-01-26 14:09:30 +01:00
Steffen Schaefer 799b1e9239 Formatting change only 2017-01-26 14:07:19 +01:00
Steffen Schaefer 62819043d2 bug 4041: Changed RegattaLogDeviceMappings to not clear its
knownRegattaLogs collection to make sure that a mapping update that is
already scheduled will consistently work. This has no impact regarding
memory leaks because the relevant action is to remove all listeners.
2017-01-26 14:03:24 +01:00
Steffen Schaefer 8488d1eddf bug 4039: Fixed ConcurrentModificationException if a listener removes
itself while it is called
2017-01-26 09:26:58 +01:00
Steffen Schaefer 8228c48cad bug 4039: Added a failing test 2017-01-26 09:23:18 +01:00
Steffen Schaefer c42a418a68 Merge branch 'bug4029' 2017-01-25 09:02:15 +01:00
Steffen Schaefer e156d6597e bug 4029 Extended MasterDataImportTest to ensure that saving batches of
fixes works as intended
2017-01-24 09:55:25 +01:00
Steffen Schaefer 0367df46eb bug 4029 Extended MasterDataImportTest to ensure that saving batches of
fixes works as intended
2017-01-24 09:55:25 +01:00
Steffen Schaefer c02148aa92 bug 4029 Fixed a copy&paste problem when calculating the import progress
of sensor fixes
2017-01-23 08:46:36 +01:00
Steffen Schaefer 94c7e9a326 bug4029 Implemented progress for sensor fixed during master data import 2017-01-19 08:37:52 +01:00
Steffen Schaefer 7c062f643d bug4029 Implemented batching for storing fixes during master data import 2017-01-19 08:15:20 +01:00
Steffen Schaefer 75d3822a49 Initial steps for saving settings in Leaderboard.html 2017-01-18 09:05:46 +01:00
Steffen Schaefer 31bd3c9dd7 Improved debuggability 2017-01-16 09:08:05 +01:00
Steffen Schaefer 46fd23f204 Merge branch 'master' into bug3529 2017-01-13 14:26:54 +01:00
Steffen Schaefer 3656358c8d Updated UserSettingsStorageManager to also work correctly if the user is
already available
2017-01-12 16:08:54 +01:00
Steffen Schaefer 9451a86978 Improved code style 2017-01-12 16:08:01 +01:00
Steffen Schaefer 36206f8435 Added a functionality to fire UserStatusEventHandler when adding it to
UserService and the user is already available
2017-01-12 16:07:12 +01:00
Steffen Schaefer 10bab90b72 Merge branch 'master' into bug3529 2017-01-11 13:54:34 +01:00
Steffen Schaefer b041e3218a rolling back changes of com.sap.sse.filestorage.test to the state of b0ca44d to make the tycho build work again 2017-01-11 10:23:23 +01:00
Steffen Schaefer fc6fece872 Added package import to org.apache.commons.logging of com.sap.sse.filestorage.test again because it turned out that this is necessary for the tests 2017-01-11 08:53:58 +01:00
Steffen Schaefer 2cfc7a5819 Added package import of commons-logging to com.sap.sse.filestorage
again, because of a NoClassDefFoundError
2017-01-10 13:36:59 +01:00
Steffen Schaefer 985676afd1 Merge branch 'foiling' 2017-01-10 11:22:08 +01:00
Steffen Schaefer 11fc432461 Added some JavaDocs to OSGiBasedTrackedRegattaListener 2017-01-10 11:21:26 +01:00
Steffen Schaefer 2c84c1a910 Formatting and removed TODO 2017-01-10 11:15:43 +01:00
Steffen Schaefer 8fa393278e Cleanup of com.sap.sse.filestorage.test. I guess this is just a leftover 2017-01-10 10:33:38 +01:00
Steffen Schaefer ba374b30d6 Removed package import to org.apache.commons.logging from bundles that
seem to not need commons-logging at all
2017-01-10 10:32:17 +01:00
Steffen Schaefer f8e1f0cdcc Merge branch 'master' into bug3529 2017-01-09 10:07:10 +01:00
Steffen Schaefer 673907c017 Merge branch 'master' into bug2447
Conflicts:
	java/com.sap.sailing.feature/feature.xml
	java/pom.xml
2017-01-09 10:05:05 +01:00
Steffen Schaefer 4517dfe6c8 Added an explanatory comment regarding concurrent behaviour of loading
tracks and processing fixes given by FixReceivedListener
2016-12-23 14:41:09 +01:00
Steffen Schaefer a8a3555aa3 Code cleanup and JavaDocs 2016-12-22 11:22:15 +01:00