Commit Graph
100 Commits
Author SHA1 Message Date
Henri Kohlberg 17282b1607 Bug 4104: Added javadoc to clarify the key of tags when tags are shared via URL. 2018-10-23 14:56:01 +02:00
Henri Kohlberg 622a410dc5 Merge branch 'master' of ssh://sapsailing.com/home/trac/git into bug4104 2018-10-18 15:07:52 +02:00
Henri Kohlberg 7227dad8cd Bug 4104: Fixed unit test for global search functionality as no user is logged in and unit tests is looking also for private tags. 2018-10-18 15:07:28 +02:00
Henri Kohlberg a6c8167dbc Bug 4104: Use DataEntryDialog to validate user input for tag & tag button creation/updating. 2018-10-18 14:59:43 +02:00
Henri Kohlberg 0f6b577eb0 Bug 4104: Display full size image instead of minified version. 2018-10-16 16:35:21 +02:00
Henri Kohlberg 3aabb4eed1 Bug 4104: Removed unused libraries which got removed in previous commits but somehow remained in respository. 2018-10-15 13:35:36 +02:00
Henri Kohlberg a1934bf5e1 Bug 4104: Adapted UI to fit new image upload form and fixed smaller bugs regarding tag buttons. 2018-10-04 15:53:27 +02:00
Henri Kohlberg 4e58a37592 Bug 4104: Added timeout for SecurityService in JUnit test. Just for testing purposes, should not be used in production! 2018-09-28 13:00:52 +02:00
Henri Kohlberg 8c145ef3bd Bug 4104: Use service tracker also for JUnit tests in OSGi environment. 2018-09-28 11:18:22 +02:00
Henri Kohlberg c67bbdd92f Bug 4104: Shared URLs of tags don't contain player mode any longer and fixed also a bug where wrong URL was generated when the current URL already contained a shared tag. 2018-09-28 11:07:40 +02:00
Henri Kohlberg cc59efcf49 Bug 4104: Adapted TaggingService and TaggingServiceTest to check their environment whether it is OSGi enabled or not and get security service from correct source (service tracker in OSGi, static reference of Activator in non-OSGi) 2018-09-28 08:28:34 +02:00
Henri Kohlberg e0249a7f64 Bug 4104: Try to fix problem with multplie userstores during hudson build (works locally) 2018-09-27 11:46:22 +02:00
Henri Kohlberg c50dbd1aa7 Bug 4104: Added tests for TagDTODeSerializer, changed output of timepoint serialization in case given timepoint is null to prevent NullPointerException and replaced toString() on JSON objects by getJSONString(). 2018-09-27 11:38:46 +02:00
Henri Kohlberg 764e8b660f Bug 4104: Drop PREFERENCES-collection when resetting environment for next unit test. 2018-09-27 09:58:59 +02:00
Henri Kohlberg 679e175a3b Bug 4104: Adapted unit test for TaggingService with more detailed log messages to identify failing tests. 2018-09-27 09:50:53 +02:00
Henri Kohlberg bb9046cdca Bug 4104: Code style 2018-09-26 16:28:38 +02:00
Henri Kohlberg e6213a934f Bug 4104: Fixed bug where other users could "take control" of other users timeslider. 2018-09-26 16:23:18 +02:00
Henri Kohlberg 7c20dbe1d2 Bug 4104: Combine all GWT Resource interfaces into one single interface. 2018-09-26 16:00:29 +02:00
Henri Kohlberg e4ea366a1e Merge branch 'master' of ssh://sapsailing.com/home/trac/git into bug4104
# Conflicts:
#	java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/server/SailingServiceImpl.java
2018-09-26 15:10:17 +02:00
Henri Kohlberg 0dd4cd75b5 Bug 4104: Added first version of unit tests for tagging backend functionality. 2018-09-26 14:57:41 +02:00
Henri Kohlberg 606caa590e Bug 4104: Changed TaggingService to support more filter options when requesting tags and adopted current implementations. 2018-09-26 14:57:00 +02:00
Henri Kohlberg 390f8a9bdf Bug 4104: Changed serialization of TagDTO so JSON objects will only contain set parameters. Optional parameters will not be added to json (revokedAt, comment, image URL) when they equal null 2018-09-26 14:55:48 +02:00
Henri Kohlberg d265f1bf5f Bug 4104: Removed completed todos, code cleanup and moved required attributes (string messages and user service) to constructor parameters of all subcomponents of TaggingPanel. 2018-09-24 16:07:32 +02:00
Henri Kohlberg 3d82b114f6 Bug 4104: Fixed error when user was not logged in and tags were requested. 2018-09-24 16:07:09 +02:00
Henri Kohlberg 356f460673 Bug 4104: Improved functionality when sharing a tag. 2018-09-24 15:57:15 +02:00
Henri Kohlberg e093012d61 Bug 4104: Fixed bug where "missing permissions" was reported but user had required permissions 2018-09-24 15:21:26 +02:00
Henri Kohlberg d92667dbaf Bug 4104: Added reload button 2018-09-24 14:16:26 +02:00
Henri Kohlberg 8f81ed62b8 Bug 4104: Minor improvements 2018-09-24 11:15:11 +02:00
Henri Kohlberg 0aee3e84d5 Bug 4104: Added new exception handling in TaggingService. 2018-09-21 17:23:54 +02:00
Henri Kohlberg 3712b9c7a4 Bug 4104: Adapted keys in user store to match naming pattern 2018-09-21 14:57:28 +02:00
Henri Kohlberg 1ea27e0e24 Bug 4104: Resized plus icon from "Add Tags" button 2018-09-21 14:44:13 +02:00
Henri Kohlberg ba76fbd465 Bug 4104: Remove private tags setting of there are no private tags stored in user store. 2018-09-21 13:30:37 +02:00
Henri Kohlberg ee9238541a Bug 4104: Renamed latestReceivedTagTime on server side to searchSince to match role. 2018-09-21 12:16:58 +02:00
Henri Kohlberg d1461376df Bug 4104: Save tag buttons as JSON array instead of an JSON object containing an array. 2018-09-21 12:04:01 +02:00
Henri Kohlberg a4d2be774a Bug 4104: Improved Javadoc, removed max length for tags and comments. 2018-09-21 11:15:16 +02:00
Henri Kohlberg e19ae426b8 Bug 4104: Added TODOs from code review and code formatting 2018-09-20 16:39:46 +02:00
Henri Kohlberg aab18db09d Merge branch 'master' of ssh://sapsailing.com/home/trac/git into bug4104 2018-09-20 09:55:57 +02:00
Henri Kohlberg 18b9bdd86d Bug 4104: Highlight most current tag when timer changes. Also removed direct write-access to list of tags at TagListProvider. 2018-09-19 17:18:32 +02:00
Henri Kohlberg f2b1fafc2c Bug 4104: Removed duplicate footer refreshes which caused unnecessary whitespace to appear 2018-09-19 16:27:42 +02:00
Henri Kohlberg 239b918a58 Bug 4104: Fixed CRUD operations on tags where the visibility was changed multiple times. 2018-09-19 16:25:29 +02:00
Henri Kohlberg 4d156c70b0 Bug 4104: Changed default visibility of new tags to "private". 2018-09-19 14:33:33 +02:00
Henri Kohlberg 7c008f0196 Bug 4104: Made permission warning less obtrusive. 2018-09-17 17:22:03 +02:00
Henri Kohlberg 10e60f38c7 Bug 4104: Added section in "Whats New" for tagging functionality. 2018-09-17 16:43:45 +02:00
Henri Kohlberg 0209c08743 Bug 4104: Fixed default visibility state for new tags (+ code formatting) 2018-09-17 16:04:07 +02:00
Henri Kohlberg 4bf6f65085 Bug 4104: Show users adapted error messages when any operation fails on server 2018-09-17 15:26:55 +02:00
Henri Kohlberg 8c2f0c15c2 Bug 4104: REST API allows to choose between only public, only private or public and private tags when loading tag via API. Revoked tags won't be delivered to client (security reasons). 2018-09-17 14:44:24 +02:00
Henri Kohlberg 6bd04c1857 Bug 4104: REST API, update tag: use old values for update when parameters are missing 2018-09-17 14:07:37 +02:00
Henri Kohlberg 7b51d52523 Bug 4104: Changed route of tags API & improved documentation. 2018-09-17 12:22:38 +02:00
Henri Kohlberg 89a7be1014 Merge branch 'master' of ssh://sapsailing.com/home/trac/git into bug4104 2018-09-17 10:37:02 +02:00
Henri Kohlberg 4e3044861a Bug 4104: Added documentation for REST API 2018-09-17 10:36:25 +02:00
Henri Kohlberg 7da7e2bf92 Bug 4104: Added 0-check for given race timepoint when creating a new tag 2018-09-17 09:02:37 +02:00
Henri Kohlberg df59662141 Bug 4104: Improved REST API (all CRUD operations are now available) 2018-09-14 15:08:26 +02:00
Henri Kohlberg 413bf691d7 Bug 4104: Improved JavaDoc 2018-09-14 12:44:31 +02:00
Henri Kohlberg 750297eb02 Bug 4104: Fixed REST API documentation 2018-09-14 11:26:24 +02:00
Henri Kohlberg c4dff979b1 Bug 4104: Save last error message per user and use enum for error codes. 2018-09-14 11:25:22 +02:00
Henri Kohlberg b56fef8e17 Merge branch 'bug4104' of ssh://sapsailing.com/home/trac/git into bug4104 2018-09-13 15:38:41 +02:00
Henri Kohlberg 06e23c425e Bug 4104: Fixed minor null check 2018-09-13 15:34:25 +02:00
Henri Kohlberg 36deb057eb Bug 4104: Improved JavaDoc 2018-09-13 15:06:58 +02:00
Henri Kohlberg f47a00f387 Bug 4104: Removed client-side DeSerializer for tags. As full backend functionality got removed from TaggingPanel, there is no need for a DeSerializer at client-side. 2018-09-13 15:06:27 +02:00
Henri Kohlberg a77bf60ce6 Bug 4104: Refactored data aquisition and extracted every backend functionality of tags into new service called TaggingService. SailingService serves as interface between client (TaggingPanel) and service (TaggingService) but does not affect any of the data itself. 2018-09-13 14:40:52 +02:00
Henri Kohlberg db1728e97a Bug 4104: Removed leftover code 2018-09-12 11:09:35 +02:00
Henri Kohlberg 9f1783c7f8 Bug 4104: Added escaping for slashes in leaderboard-/racecolumn-/fleetname 2018-09-12 11:09:08 +02:00
Henri Kohlberg 4c03df87f0 Bug 4104: Save timepoints as long instead of a string in JSON. 2018-09-12 11:06:20 +02:00
Henri Kohlberg be101a6a66 Merge branch 'bug4104' of ssh://sapsailing.com/home/trac/git into bug4104 2018-09-11 15:38:24 +02:00
Henri Kohlberg 89649cddce Bug 4104: Added first draft of REST API for tags. Allows to receive all public tags in general and appends them by private tags in case user is logged in. 2018-09-11 15:38:01 +02:00
Henri Kohlberg 1c72251d77 Bug 4104: Split TagDTO-DeSerializer to allow usage of common methods at client- & server-side as there is no common JSON-library for client and server. TagDTO-DeSerializer requires possibility to only work with JSON-strings instead of JSON-Object from any library. 2018-09-11 15:36:44 +02:00
Henri Kohlberg abe6959120 Bug 4104: Moved comment to correct lines 2018-09-10 15:21:25 +02:00
Henri Kohlberg ba2d5e4711 Bug 4104: Fixed newly created Tag-Buttons which could not create new tags until page was reload 2018-09-10 15:21:06 +02:00
Henri Kohlberg cc790c9c22 Bug 4104: Moved TagDTO to be available in upcoming REST Servlet. 2018-09-10 15:20:12 +02:00
Henri Kohlberg 1f0efcf7c1 Bug 4104: Fixed german translation 2018-09-10 10:11:15 +02:00
Henri Kohlberg e84ebbbde8 Bug 4104: Added tooltips for action buttons in tag cell 2018-09-10 10:10:20 +02:00
Henri Kohlberg a27156c067 Bug 4104: Highlight tag which gets edited by user 2018-09-10 09:51:00 +02:00
Henri Kohlberg 77275ea138 Bug 4104: Asks user to confirm cancelation of tag button changes 2018-09-10 09:07:38 +02:00
Henri Kohlberg 9fd278ad93 Bug 4104: Fixed footer panel visibility when user does not have saved Tag-Buttons and Tagging-Panel is in View-Mode. 2018-09-10 08:49:19 +02:00
Henri Kohlberg 2d391d5b59 Bug 4104: Fixed visibility issues of north/south splitter which always need to be visible. 2018-09-10 08:40:39 +02:00
Henri Kohlberg 1b10213e21 Bug 4104: Fixed dragger visibility of horizontal splitter on mobile devices when leaderboard is loaded not visible. 2018-09-07 15:17:27 +02:00
Henri Kohlberg eef1b16a49 Merge branch 'master' of ssh://sapsailing.com/home/trac/git into bug4104 2018-09-07 10:08:54 +02:00
Henri Kohlberg 23885bd0ac Bug 4104: Disabled tag selection when another tag gets edited and improved/fixed UI. 2018-09-07 10:05:00 +02:00
Henri Kohlberg 4c36cd085f Bug 4104: Allow editing of tags. 2018-09-06 17:25:35 +02:00
Henri Kohlberg 66a2a4d562 Bug 4104: Renamed state EDIT to CREATE_TAG to match meaning 2018-09-05 17:23:58 +02:00
Henri Kohlberg 7a87fddb97 Bug 4104: Simplified & formatted code 2018-09-05 17:22:37 +02:00
Henri Kohlberg eb29ed0ae5 Revert "Bug 4104: Fixed search via searchbox when no filterset is selected."
This reverts commit 3b6aac6e51.
2018-09-05 15:39:06 +02:00
Henri Kohlberg 3b6aac6e51 Bug 4104: Fixed search via searchbox when no filterset is selected. 2018-09-05 15:35:56 +02:00
Henri Kohlberg af5e57c9a2 Bug 4104: Improved JavaDoc coverage and removed unused classes. 2018-09-05 15:05:29 +02:00
Henri Kohlberg a01e0e979c Bug 4104: Removed max length of image URL. 2018-09-05 12:58:34 +02:00
Henri Kohlberg fc5ed6b317 Bug 4104: Added warning message when user creates a new tag if tag already exists (e.g. by pressing a tag-button multiple times at the same time slider position) 2018-09-05 12:38:04 +02:00
Henri Kohlberg 75369ab2b6 Bug 4104: Improved layout of tag-headings in tag celllist. 2018-09-05 11:25:18 +02:00
Henri Kohlberg 852bb5cabf Bug 4104: Improved TagButton-table layout and positioning. 2018-09-05 10:05:57 +02:00
Henri Kohlberg 434b62338a Bug 4104: Removed column "Visibility" in TagButtonDialog and added visibility information at tag column. 2018-09-05 09:52:57 +02:00
Henri Kohlberg 4df9377669 Bug 4104: Changed pen icon to plus icon for "Add Tags"-button. 2018-09-05 08:31:01 +02:00
Henri Kohlberg 5b100b2b16 Bug 4104: Changed observer label from a single label to multiple labels. 2018-09-04 16:22:38 +02:00
Henri Kohlberg be3392b498 Bug 4104: Added Javadoc comments in com.sap.sailing.gwt.ui.raceboard.tagging package. 2018-09-04 16:13:07 +02:00
Henri Kohlberg 08a685fee0 Bug 4104: Added missing translation 2018-09-03 16:58:14 +02:00
Henri Kohlberg 37e4e80cd5 Bug 4104: Separated tag buttons from tag input fields. 2018-09-03 16:49:49 +02:00
Henri Kohlberg 12b1d8daad Bug 4104: Fixed overlapping elements in tagging panel. 2018-09-03 14:03:31 +02:00
Henri Kohlberg cace306d0f Merge branch 'master' of ssh://sapsailing.com/home/trac/git into bug4104
# Conflicts:
#	java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/client/StringMessages.properties
2018-09-03 11:24:41 +02:00
Henri Kohlberg 623253561e Bug 4104: Improved UI 2018-08-31 14:20:27 +02:00
Henri Kohlberg dc174f500e Bug 4104: Changed CSS files to GSS files to support CSS 3. 2018-08-31 12:47:15 +02:00
Henri Kohlberg 3a545afa33 Bug 4104: Moved private class into own classes and created package com.sap.sailing.gwt.ui.raceboard.tagging which contains all files. 2018-08-31 12:26:31 +02:00
Henri Kohlberg 99a4c4c1e0 Bug 4104: Improved documentation 2018-08-24 09:53:13 +02:00